[help-needed] MKS TFT thumbnails #3387

adripo · 2022-10-30T21:22:58Z

Implementation of MKS TFT thumbnails for other printers than Biqu.
I was inspired by this PR ArtificalSUN/MKS-WIFI_PS_uploader#5 but I don't have much experience in c++.

I would like to get some help to convert the logic that can be found here:
https://github.com/Jeredian/mks-wifi-plugin/blob/develop/MKSPreview.py#L21
and here
https://github.com/SH1NZ33/MKS-WIFI_PS_uploader/blob/patch-1/MKS_WIFI_PS_upload.pyw#L31

For the moment I copied the conversion from Biqu.
The sections that need to be checked and edited are:

I can test any file on my FlyingBear 4S.

fix #3064

fix createrelease as the mac arm can't be compiled on github anymore

Added a piece of code into handle_legacy to check for aliases. '.mf3 files won't open 2.4.58.3' supermerill#2939

supermerill#2934

…one click instead of two (recovering the old behavior).

supermerill#1607

…amming for klipper. supermerill#2934

supermerill#2961

Mitigation: remove shallow angles that seems to make it appear. As the previous remove_colinear was on a fixed dist (taht became too small on long segments) I created a new one that work from an angle. supermerill#2971

supermerill#2969

…eird filesystems. supermerill#2938

supermerill#2968

And fix for the visualization of the spiral start.

supermerill#2967

…rial. supermerill#2970

supermerill#2979

supermerill#3110

supermerill/issues/3125

fix refresh for float/&percent fixed ask_for_refresh() for non-bool supermerill#3175

supermerill#3153

…CE if the extruder name is blank supermerill#3073

supermerill#3185

…& no layer_gcode supermerill#2916

supermerill#2639

supermerill#2739 supermerill#2786

supermerill#3176

(maybe still some quirks for raft with many extruders).

adripo · 2022-10-30T21:36:03Z

The previews are visible, but the colors are not correct. Here are some examples:

original:

preview:

thumbnail:

supermerill · 2023-01-06T10:10:14Z

can you try instead of

            uint16_t pixel = 0;
            //r
            pixel |= uint16_t((rgba_pixels[y * row_size + x * 4 + 0 ] & 0x000000F8) >> 3);
            //g
            pixel |= uint16_t((rgba_pixels[y * row_size + x * 4 + 1 ] & 0x000000FC) << 3);
            //b
            pixel |= uint16_t((rgba_pixels[y * row_size + x * 4 + 2 ] & 0x000000F8) << 8);
            tohex << std::setw(4) << pixel;

to use

            uint16_t pixel = 0;
            //r
            pixel |= uint16_t(((rgba_pixels[y * row_size + x * 4 + 0 ] & 0x000000FF) >> 3) << 11);
            //g
            pixel |= uint16_t(((rgba_pixels[y * row_size + x * 4 + 1 ] & 0x000000FF)  >> 2) <<5);
            //b
            pixel |= uint16_t((rgba_pixels[y * row_size + x * 4 + 2 ] & 0x000000FF) >> 3);
            tohex << std::setw(4) << pixel;

#3387

supermerill · 2023-01-06T10:33:45Z

also it seems you didn't pushed a working version, as it doesn't compile

LuckyTurtleDev and others added 30 commits July 19, 2022 20:12

add "in repo" badge

635575a

change release names

6b7551f

Update badges

f266b18

update min_width_top_surface tooltip

6c6ee47

fix buildlinux for 22.04

e343bc7

fix createrelease as the mac arm can't be compiled on github anymore

Fix config loading for brim_offset

5c73d9d

Added a piece of code into handle_legacy to check for aliases. '.mf3 files won't open 2.4.58.3' supermerill#2939

Don't disable pressure advance if no ramming for the wipe tower.

fe2335b

supermerill#2934

Add a "tag" menu next to the "mode", so the "mode" can be changed in …

7f20a19

…one click instead of two (recovering the old behavior).

Search now compare all lowercase.

5019d2b

Fix some to_prusa config convert (extrusion width %)

c713405

perimeter_round_corners tooltip

aa04e29

supermerill#1607

Set the extruder for disabling pressure advance in wipetower before r…

960db82

…amming for klipper. supermerill#2934

Don't rely on gcode to detect a toolchange for cooling buffers.

48b2cdf

supermerill#2961

Fix of 8299 (Linux crash when selecting locales)

ac5d906

stackwalker for better log on exception on windows

8c4c561

render vertices_and_normals_interleaved_VBO_id assert fix?

fa59f22

update for sidetext_width labels

e7eee61

fix unwanted extra gapfill (boost::voronoi bug)

3527f6e

Mitigation: remove shallow angles that seems to make it appear. As the previous remove_colinear was on a fixed dist (taht became too small on long segments) I created a new one that work from an angle. supermerill#2971

Fix freecad path for linux

63e5344

supermerill#2969

Using internal copy_file instead of the boost one, to not fail with w…

c5dbc6d

…eird filesystems. supermerill#2938

Fix extrusion hint when using default extrusion.

4a55b34

supermerill#2968

Fix duplicate points when polyline.split_at on an existing point

5ccbd7f

Allow smooth start for spiral_vase also in extruder absolute mode

3d5eb91

And fix for the visualization of the spiral start.

Add a way to deactivate the anti-hysteresis check for perimeters.

061c018

supermerill#2967

Add preference option to shsow pop-up on export about he current mate…

f65663e

…rial. supermerill#2970

fix rounding problem disabling variable layer height

cb13e75

supermerill#2979

Update max_volumetric_speed tooltip: it's really a max_volumetric_speed

ce85ac8

Allow some more contrast for the first color change color.

4a0d00a

Fix to_prusa from 1b8190e & d16b7d1 new settings.

13eed23

Fix spiral_vase (from 2.4 merge: multithreading issue)

a16466a

supermerill and others added 21 commits September 16, 2022 16:13

Fix autospeed: max print speed %

7a9ee2f

supermerill#3110

Fix first layer z position i the gcode viewer.

ac65598

supermerill/issues/3125

Profile: fix creality brace in filename.

6b5e537

supermerill#3157

Fix search / unsaved changes for setting arrays

71dde0c

supermerill#1052

don't unretract when wiping if using firmware retraction.

bb7fef4

supermerill#3163

Fix default reset of scripted widgets

d6cbc55

supermerill#3144

Fix icon splashscreen

2c379a2

supermerill#3135

scripted widget: now executed at conf load, to apply changes

4792683

fix refresh for float/&percent fixed ask_for_refresh() for non-bool supermerill#3175

undo 7e3fc96, not needed anymore

5efbb72

supermerill#3153

wipetower with klipper: don't pass the extruder to SET_PRESSURE_ADVAN…

9c81fa4

…CE if the extruder name is blank supermerill#3073

Fix double brim interior

0ff485c

supermerill#3185

fix missing retraction when the lift is merged in start_gcode_manual …

fe6d2ba

…& no layer_gcode supermerill#2916

Fix mmu paint

0981595

supermerill#2639

Fix milling post-process

3466946

supermerill#2739 supermerill#2786

Fix gui not refreshing for 'single extruder mmu' tab

884e0fd

supermerill#3176

Correct computation for empty layers.

ceec9d7

(maybe still some quirks for raft with many extruders).

Fix thinwall-merge to keep a real loop

cc59dbd

fix compile

079ffaa

version 2.4.58.5

76856c5

feat: create TFT option for thumbnails

8048e87

fix: tft thumbnails

2139156

This was referenced Oct 30, 2022

MKS Thumbnail Support? #3064

Open

Thumbnail/Gcode Preview for Slic3r/PrusaSlicer/SuperSlicer for BigTreeTech TFT Screens #887

Open

adripo changed the title ~~TFT thumbnails~~ [help-needed] TFT thumbnails Oct 30, 2022

adripo changed the title ~~[help-needed] TFT thumbnails~~ [help-needed] MKS TFT thumbnails Oct 30, 2022

supermerill pushed a commit that referenced this pull request Jan 6, 2023

create TFT option for thumbnails

7c09da7

#3387

supermerill force-pushed the master branch from 45d0532 to 69c3980 Compare November 24, 2023 22:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[help-needed] MKS TFT thumbnails #3387

[help-needed] MKS TFT thumbnails #3387

adripo commented Oct 30, 2022 •

edited

Loading

adripo commented Oct 30, 2022

supermerill commented Jan 6, 2023

supermerill commented Jan 6, 2023

[help-needed] MKS TFT thumbnails #3387

Are you sure you want to change the base?

[help-needed] MKS TFT thumbnails #3387

Conversation

adripo commented Oct 30, 2022 • edited Loading

adripo commented Oct 30, 2022

supermerill commented Jan 6, 2023

supermerill commented Jan 6, 2023

adripo commented Oct 30, 2022 •

edited

Loading